Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp

Issue 1670743002: Move V8 extra-calling utilities to V8ScriptRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
index 36590becef6a1678e29cdf02e7882008aaee6b30..024320b1d9628118c51d2d979ff1d7faa2fc397d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
@@ -6,7 +6,7 @@
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/ScriptState.h"
-#include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8ScriptRunner.h"
namespace blink {
@@ -16,7 +16,7 @@ ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, Script
v8::TryCatch block(scriptState->isolate());
v8::Local<v8::Value> args[] = { stream.v8Value() };
- ScriptValue result(scriptState, v8CallExtra(scriptState, "AcquireReadableStreamReader", args));
+ ScriptValue result(scriptState, V8ScriptRunner::callExtra(scriptState, "AcquireReadableStreamReader", args));
if (block.HasCaught())
es.rethrowV8Exception(block.Exception());
return result;
@@ -30,7 +30,7 @@ bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, Script
return false;
v8::Local<v8::Value> args[] = { value.v8Value() };
- return v8CallExtraOrCrash(scriptState, "IsReadableStream", args)->ToBoolean()->Value();
+ return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStream", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, ScriptValue stream)
@@ -38,7 +38,7 @@ bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, ScriptValue
ASSERT(isReadableStream(scriptState, stream));
v8::Local<v8::Value> args[] = { stream.v8Value() };
- return v8CallExtraOrCrash(scriptState, "IsReadableStreamDisturbed", args)->ToBoolean()->Value();
+ return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamDisturbed", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isLocked(ScriptState* scriptState, ScriptValue stream)
@@ -46,7 +46,7 @@ bool ReadableStreamOperations::isLocked(ScriptState* scriptState, ScriptValue st
ASSERT(isReadableStream(scriptState, stream));
v8::Local<v8::Value> args[] = { stream.v8Value() };
- return v8CallExtraOrCrash(scriptState, "IsReadableStreamLocked", args)->ToBoolean()->Value();
+ return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamLocked", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, ScriptValue value)
@@ -57,7 +57,7 @@ bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState,
return false;
v8::Local<v8::Value> args[] = { value.v8Value() };
- return v8CallExtraOrCrash(scriptState, "IsReadableStreamReader", args)->ToBoolean()->Value();
+ return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamReader", args)->ToBoolean()->Value();
}
ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, ScriptValue reader)
@@ -65,7 +65,7 @@ ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, ScriptVal
ASSERT(isReadableStreamReader(scriptState, reader));
v8::Local<v8::Value> args[] = { reader.v8Value() };
- return ScriptPromise::cast(scriptState, v8CallExtraOrCrash(scriptState, "ReadFromReadableStreamReader", args));
+ return ScriptPromise::cast(scriptState, V8ScriptRunner::callExtraOrCrash(scriptState, "ReadFromReadableStreamReader", args));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698