Move V8 extra-calling utilities to V8ScriptRunner

Move V8 extra-calling utilities to V8ScriptRunner

As discussed in https://codereview.chromium.org/1167343002. Also used callInternalFunction instead of callFunction.

BUG=

Committed: https://crrev.com/fbf579e78e3cabdd8d39c1fe7622f8f5b40c2735
Cr-Commit-Position: refs/heads/master@{#373748}

[domenic, 2016-02-04 22:20:23]

domenic@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-02-05 00:56:41]

LGTM, thanks!

https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h (right):

https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h:30: #include
"bindings/core/v8/ScriptValue.h"

This wouldn't be needed.

[chromium-reviews, 2016-02-05 00:59:19]

It ends up being needed because getExtrasExportsObject returns a
ScriptValue. And if you move it into the header where that is defined, you
get circularity errors

On Thu, Feb 4, 2016, 19:56  <haraken@chromium.org> wrote:

>
> LGTM, thanks!
>
>
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
> (right):
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h:30
<https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...>:
#include
> "bindings/core/v8/ScriptValue.h"
>
> This wouldn't be needed.
> https://codereview.chromium.org/1670743002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-02-05 00:59:19]

It ends up being needed because getExtrasExportsObject returns a
ScriptValue. And if you move it into the header where that is defined, you
get circularity errors

On Thu, Feb 4, 2016, 19:56  <haraken@chromium.org> wrote:

>
> LGTM, thanks!
>
>
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
> (right):
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h:30
<https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...>:
#include
> "bindings/core/v8/ScriptValue.h"
>
> This wouldn't be needed.
> https://codereview.chromium.org/1670743002/
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[haraken, 2016-02-05 01:05:31]

On 2016/02/05 00:59:19, blink-reviews wrote:
> It ends up being needed because getExtrasExportsObject returns a
> ScriptValue. And if you move it into the header where that is defined, you
> get circularity errors
> 
> On Thu, Feb 4, 2016, 19:56  <mailto:haraken@chromium.org> wrote:
> 
> >
> > LGTM, thanks!
> >
> >
> >
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> > File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
> > (right):
> >
>
https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...
> > third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h:30
>
<https://codereview.chromium.org/1670743002/diff/1/third_party/WebKit/Source/b...>:
> #include
> > "bindings/core/v8/ScriptValue.h"
> >
> > This wouldn't be needed.
> > https://codereview.chromium.org/1670743002/
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Blink
> Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

Makes sense :)

[domenic, 2016-02-05 03:46:49]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2016-02-05 03:47:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670743002/1

[commit-bot: I haz the power, 2016-02-05 05:11:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-05 05:12:49]

Description was changed from

==========
Move V8 extra-calling utilities to V8ScriptRunner

As discussed in https://codereview.chromium.org/1167343002. Also used
callInternalFunction instead of callFunction.

BUG=
==========

to

==========
Move V8 extra-calling utilities to V8ScriptRunner

As discussed in https://codereview.chromium.org/1167343002. Also used
callInternalFunction instead of callFunction.

BUG=

Committed: https://crrev.com/fbf579e78e3cabdd8d39c1fe7622f8f5b40c2735
Cr-Commit-Position: refs/heads/master@{#373748}
==========

[commit-bot: I haz the power, 2016-02-05 05:12:50]

Patchset 1 (id:??) landed as
https://crrev.com/fbf579e78e3cabdd8d39c1fe7622f8f5b40c2735
Cr-Commit-Position: refs/heads/master@{#373748}