[SystemInfo API] Rewrite storage info provider using storage monitor impl.

chrome/common/extensions/api/experimental_system_info_storage.idl

Index: chrome/common/extensions/api/experimental_system_info_storage.idl
diff --git a/chrome/common/extensions/api/experimental_system_info_storage.idl b/chrome/common/extensions/api/experimental_system_info_storage.idl
index 85ad8983ca1099def8e89b38125df0ee404331c8..78a20574229e8b8039cbf6f5dd442ab2fa194ba6 100644
--- a/chrome/common/extensions/api/experimental_system_info_storage.idl
+++ b/chrome/common/extensions/api/experimental_system_info_storage.idl
@@ -16,18 +16,20 @@ namespace experimental.systemInfo.storage {
   };
 
   dictionary StorageUnitInfo {
-    // The unique id of the storage unit.
+    // The unique storage id. It will use the transient ID.
     DOMString id;
+    // The name of the storage unit.
+    DOMString name;
     // The media type of the storage unit.
     StorageUnitType type;
-    // The total amount of the storage space, in bytes.
+    // The total amount of the storage space, in bytes, default value is 0.

[Jeffrey Yasskin, 2013/07/02 23:00:50]

What does "default" mean here? Storage units don't have default sizes, they just
have sizes.

[Haojian Wu, 2013/07/03 16:23:49]

If we can't establish the capacity or available capacity, these variables will
be set to the default value.

[Greg Billock, 2013/07/03 17:33:57]

Maybe the comment should be "If the storage size cannot be determined, it will
have a 0 value." That's ambiguous for availableCapacity though. :-(

     double capacity;
-    // The available amount of the storage space, in bytes.
+    // The available amount of the storage space, in bytes, default value is 0.
     double availableCapacity;
   };
 
-  dictionary StorageChangeInfo {
-    // The uniue id of the storage unit already changed.
+  dictionary StorageCapacityChangeInfo {

[Jeffrey Yasskin, 2013/07/02 23:00:50]

It's not the capacity that's changing with this event, it's the available space.
So "StorageAvailabilityChangeInfo" or "StorageFreeSpaceChangeInfo"?

[Haojian Wu, 2013/07/03 16:23:49]

Done. But the current name "StorageCapacityChangeInfo" is based on Billock's
suggestions.

[Greg Billock, 2013/07/03 17:33:57]

Either way is fine with me. I think "StorageAvailabilityChangeInfo" is
misleading, though -- sounds like whether the storage is avilable or not, not
about available capacity.

[Haojian Wu, 2013/07/04 00:41:17]

Now rename to StorageFreeSpaceChangeInfo.

+    // The unique id of the storage unit already changed.

[Jeffrey Yasskin, 2013/07/02 23:00:50]

s/already/that/ I think.

[Haojian Wu, 2013/07/03 16:23:49]

Done.

     DOMString id;
     // The new value of the available capacity.
     double availableCapacity;
@@ -67,7 +69,7 @@ namespace experimental.systemInfo.storage {
   interface Events {
     // Fired when the storage device available capacity is changed.
     // |info|: The changed information for the specified storage unit.
-    static void onAvailableCapacityChanged(StorageChangeInfo info);
+    static void onAvailableCapacityChanged(StorageCapacityChangeInfo info);
 
     // Fired when a new removable storage is attached to the system.
     static void onAttached(StorageUnitInfo info);