[SystemInfo API] Rewrite storage info provider using storage monitor impl.

chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

Index: chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc
diff --git a/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc b/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2d27dbed34719127b0abf39a2fa94b5f7bcdadd6
--- /dev/null
+++ b/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc
@@ -0,0 +1,97 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.h"
+
+#include "base/strings/utf_string_conversions.h"
+
+using extensions::api::experimental_system_info_storage::ParseStorageUnitType;
+using extensions::api::experimental_system_info_storage::StorageUnitInfo;
+using extensions::StorageInfoProvider;
+using extensions::systeminfo::kStorageTypeFixed;
+using extensions::systeminfo::kStorageTypeRemovable;
+using extensions::systeminfo::kStorageTypeUnknown;
+
+// Watching interval for testing.
+const size_t kTestingIntervalMS = 10;
+
+TestStorageInfoProvider::TestStorageInfoProvider(
+    const struct TestUnitInfo* testing_data, size_t n)
+      : testing_data_(testing_data, testing_data + n) {
+    SetWatchingIntervalForTesting(kTestingIntervalMS);
+}
+
+TestStorageInfoProvider::~TestStorageInfoProvider() {
+}
+
+// static
+chrome::StorageInfo TestStorageInfoProvider::BuildStorageInfo(
+    const TestUnitInfo& unit) {
+  chrome::StorageInfo info(
+      unit.device_id,
+      UTF8ToUTF16(unit.name),
+      base::FilePath::StringType(), /* no location */
+      string16(), /* no storage label */
+      string16(), /* no storage vendor */
+      string16(), /* no storage model */
+      unit.capacity);
+  return info;
+}
+
+bool TestStorageInfoProvider::QueryInfo(extensions::StorageInfo* info) {
+  extensions::StorageInfo results;

[Jeffrey Yasskin, 2013/07/02 23:00:50]

Unless there's a reason I'm missing, call info->clear(), and then push directly
into *info. (which you could rename to results)

[Haojian Wu, 2013/07/03 16:23:49]

Done.

+  for (size_t i = 0; i < testing_data_.size(); ++i) {
+    linked_ptr<StorageUnitInfo> unit(new StorageUnitInfo());
+    unit->id = testing_data_[i].transient_id;
+    unit->name = testing_data_[i].name;
+    unit->type = ParseStorageUnitType(testing_data_[i].type);
+    unit->capacity = testing_data_[i].capacity;
+    unit->available_capacity = testing_data_[i].available_capacity;
+    results.push_back(unit);
+  }
+  info->swap(results);
+  return true;
+}
+
+std::vector<chrome::StorageInfo>
+TestStorageInfoProvider::GetAllStorages() const {
+  std::vector<chrome::StorageInfo> results;
+  for (size_t i = 0; i < testing_data_.size(); ++i)
+    results.push_back(BuildStorageInfo(testing_data_[i]));
+
+  return results;
+}
+
+int64 TestStorageInfoProvider::GetStorageFreeSpaceFromTransientId(
+    const std::string& transient_id) {
+  int64 available_capacity = -1;
+  for (size_t i = 0; i < testing_data_.size(); ++i) {
+    if (testing_data_[i].transient_id == transient_id) {
+      available_capacity = testing_data_[i].available_capacity;
+      // We simulate free space change by increasing the |available_capacity|

[Jeffrey Yasskin, 2013/07/02 23:00:50]

But free space can never shrink? That seems like an odd test, especially with
your logic about the old size being 0.

[Haojian Wu, 2013/07/03 16:23:49]

There is one test data which the change_step is 0.

[Jeffrey Yasskin, 2013/07/03 21:44:48]

change_step==0 just means the size doesn't change, not that the old size is 0.

I think your whole testing strategy is probably going to need to change: I'd
expect an interface that represents the system storage functions, with a
googlemock implementation that lets you specify the exact order of results.
That'll let you remove your little programming language in TestUnitInfo and
nearly all of the virtual functions in StorageInfoProvider. However, that's a
bigger change than you need to do in this CL.

[Haojian Wu, 2013/07/04 00:41:17]

Add TODO in TestStorageInfoProvider header.

+      // with a fixed change step.
+      testing_data_[i].available_capacity += testing_data_[i].change_step;
+      break;
+    }
+  }
+  return available_capacity;
+}
+
+std::string TestStorageInfoProvider::GetTransientIdForDeviceId(
+    const std::string& device_id) const {
+  for (size_t i = 0; i < testing_data_.size(); ++i) {
+    if (testing_data_[i].device_id == device_id)
+      return testing_data_[i].transient_id;
+  }
+  return std::string();
+}
+
+std::string TestStorageInfoProvider::GetDeviceIdForTransientId(
+    const std::string& transient_id) const {
+  for (size_t i = 0; i < testing_data_.size(); ++i) {
+    if (testing_data_[i].transient_id == transient_id)
+      return testing_data_[i].device_id;
+  }
+  return std::string();
+}