Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org

Committed: https://crrev.com/26511aef79e6b23a92c8956976588786f09a2e42
Cr-Commit-Position: refs/heads/master@{#374686}

[melandory, 2016-02-05 00:16:08]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 00:19:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670673004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670673004/40001

[commit-bot: I haz the power, 2016-02-05 00:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 00:58:56]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[melandory, 2016-02-05 17:02:46]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2016-02-05 17:02:46]

vabr@chromium.org, please take a look

chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.cc
chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc	
chrome/browser/ui/passwords/manage_passwords_view_utils.h
chrome/browser/ui/passwords/manage_passwords_view_utils.cc

[vabr (Chromium), 2016-02-08 09:12:29]

On 2016/02/05 17:02:46, melandory wrote:
> mailto:vabr@chromium.org, please take a look
> 
> chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
> chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.cc
> chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc	
> chrome/browser/ui/passwords/manage_passwords_view_utils.h
> chrome/browser/ui/passwords/manage_passwords_view_utils.cc

The changes in the above files LGTM.

Could you please also add a reason for the revert in the CL description?

Thanks!
Vaclav

[melandory, 2016-02-09 17:00:31]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2016-02-09 17:00:31]

dfalcantara@chromium.org: Please review changes in 

chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfoBar.java
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.cc

[melandory, 2016-02-09 17:00:56]

Description was changed from

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

BUG=532876
==========

to

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
==========

[melandory, 2016-02-09 17:01:16]

melandory@chromium.org changed reviewers:
+ tedchoc@chromium.org

[melandory, 2016-02-09 17:01:17]

tedchoc@chromium.org: Please review changes in 

chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

[Ted C, 2016-02-09 17:22:22]

lgtm w/ nit

https://codereview.chromium.org/1670673004/diff/80001/chrome/browser/ui/andro...
File chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
(right):

https://codereview.chromium.org/1670673004/diff/80001/chrome/browser/ui/andro...
chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc:22: JNIEnv*
env = base::android::AttachCurrentThread();
decrease the intent of this section now?

[melandory, 2016-02-10 00:11:57]

https://codereview.chromium.org/1670673004/diff/80001/chrome/browser/ui/andro...
File chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
(right):

https://codereview.chromium.org/1670673004/diff/80001/chrome/browser/ui/andro...
chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc:22: JNIEnv*
env = base::android::AttachCurrentThread();
On 2016/02/09 17:22:22, Ted C wrote:
> decrease the intent of this section now?

Done.

[melandory, 2016-02-10 01:31:59]

Description was changed from

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
==========

to

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org
==========

[melandory, 2016-02-10 01:32:07]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 01:33:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670673004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670673004/100001

[commit-bot: I haz the power, 2016-02-10 02:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 02:47:18]

Dry run: This issue passed the CQ dry run.

[melandory, 2016-02-10 17:54:26]

The CQ bit was checked by melandory@chromium.org

[melandory, 2016-02-10 17:54:27]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1670673004/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-10 17:56:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670673004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670673004/100001

[commit-bot: I haz the power, 2016-02-10 18:07:49]

Description was changed from

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org
==========

to

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org
==========

[commit-bot: I haz the power, 2016-02-10 18:07:50]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-10 18:08:46]

Description was changed from

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org
==========

to

==========
Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org

Committed: https://crrev.com/26511aef79e6b23a92c8956976588786f09a2e42
Cr-Commit-Position: refs/heads/master@{#374686}
==========

[commit-bot: I haz the power, 2016-02-10 18:08:47]

Patchset 6 (id:??) landed as
https://crrev.com/26511aef79e6b23a92c8956976588786f09a2e42
Cr-Commit-Position: refs/heads/master@{#374686}