chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc - Issue 1670673004: Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

Issue 1670673004: Revert "[Smart Lock, UI] First run expience for Auto sign-in prompt." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.cc ('k') | chrome/browser/ui/passwords/manage_passwords_view_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

diff --git a/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc b/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

index 2edc8a5385b393b0815516f564ada0fc92f0c493..c3e6d6a28b726d2b92152c29f3c48a1866b40480 100644

--- a/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

+++ b/chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

@@ -7,7 +7,6 @@

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

#include "chrome/browser/android/tab_android.h"

-#include "chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/grit/generated_resources.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

@@ -17,22 +16,15 @@

void ShowAutoSigninPrompt(content::WebContents* web_contents,

const base::string16& username) {

- Profile* profile =

- Profile::FromBrowserContext(web_contents->GetBrowserContext());

base::string16 message = l10n_util::GetStringFUTF16(

IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_TITLE, username);

- if (password_bubble_experiment::ShouldShowAutoSignInPromptFirstRunExperience(

- profile->GetPrefs())) {

- AutoSigninFirstRunInfoBarDelegate::Create(web_contents, message);

- } else {

- JNIEnv* env = base::android::AttachCurrentThread();

- TabAndroid* tab = TabAndroid::FromWebContents(web_contents);

- ScopedJavaLocalRef<jstring> java_message =

- base::android::ConvertUTF16ToJavaString(env, message);

- Java_AutoSigninSnackbarController_showSnackbar(

- env, tab->GetJavaObject().obj(), java_message.obj());

- }

+ JNIEnv* env = base::android::AttachCurrentThread();

+ TabAndroid* tab = TabAndroid::FromWebContents(web_contents);

+ ScopedJavaLocalRef<jstring> java_message =

+ base::android::ConvertUTF16ToJavaString(env, message);

+ Java_AutoSigninSnackbarController_showSnackbar(

+ env, tab->GetJavaObject().obj(), java_message.obj());

}

bool RegisterAutoSigninSnackbarController(JNIEnv* env) {