chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js - Issue 1670673003: Refactor the implementation of the webNavigation extension API.

Unified Diff: chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js

Issue 1670673003: Refactor the implementation of the webNavigation extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-532666-NavigationHandleAPI

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js ('K') | « chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/framework.js ('k') | chrome/test/data/extensions/api_test/webnavigation/download/framework.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js

diff --git a/chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js b/chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js

index 8912831f29da0b2a76d248d0619c4d5554a4b82b..8a57a31c2a0bdaa30a6d81f47540072fb5ede0ce 100644

--- a/chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js

+++ b/chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js

@@ -36,7 +36,7 @@ onload = function() {

event: 'onBeforeNavigate',

details: { frameId: 0,

parentFrameId: -1,

- processId: 0,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_MAIN }},

@@ -63,28 +63,11 @@ onload = function() {

tabId: 0,

timeStamp: 0,

url: URL_MAIN }},

- // pre-a.com is the navigation before the process swap.

- { label: 'pre-a.com-onBeforeNavigate',

- event: 'onBeforeNavigate',

- details: { frameId: 1,

- parentFrameId: 0,

- processId: 0,

- tabId: 0,

- timeStamp: 0,

- url: URL_FRAME1 }},

- { label: 'pre-a.com-onErrorOccurred',

- event: 'onErrorOccurred',

- details: { error: 'net::ERR_ABORTED',

- frameId: 1,

- processId: 0,

- tabId: 0,

- timeStamp: 0,

- url: URL_FRAME1 }},

{ label: 'a.com-onBeforeNavigate',

event: 'onBeforeNavigate',

details: { frameId: 1,

parentFrameId: 0,

- processId: 1,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_FRAME1 }},

@@ -120,7 +103,7 @@ onload = function() {

event: 'onBeforeNavigate',

details: { frameId: 1,

parentFrameId: 0,

- processId: 2,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_FRAME2 }},

@@ -147,28 +130,11 @@ onload = function() {

tabId: 0,

timeStamp: 0,

url: URL_FRAME2 }},

- // pre-c.com is the navigation before the process swap.

- { label: 'pre-c.com-onBeforeNavigate',

- event: 'onBeforeNavigate',

- details: { frameId: 1,

- parentFrameId: 0,

- processId: 2,

- tabId: 0,

- timeStamp: 0,

- url: URL_FRAME3 }},

- { label: 'pre-c.com-onErrorOccurred',

- event: 'onErrorOccurred',

- details: { error: 'net::ERR_ABORTED',

- frameId: 1,

- processId: 2,

- tabId: 0,

- timeStamp: 0,

- url: URL_FRAME3 }},

{ label: 'c.com-onBeforeNavigate',

event: 'onBeforeNavigate',

details: { frameId: 1,

parentFrameId: 0,

- processId: 3,

+ processId: -1,

tabId: 0,

timeStamp: 0,

url: URL_FRAME3 }},

@@ -200,10 +166,9 @@ onload = function() {

navigationOrder('a.com-'),

navigationOrder('b.com-'),

navigationOrder('c.com-'),

- ['pre-a.com-onBeforeNavigate', 'a.com-onBeforeNavigate',

- 'pre-a.com-onErrorOccurred'],

- ['pre-c.com-onBeforeNavigate', 'c.com-onBeforeNavigate',

- 'pre-c.com-onErrorOccurred']]);

+ ['a.com-onCommitted', 'b.com-onBeforeNavigate'],

+ ['b.com-onCommitted', 'c.com-onBeforeNavigate'],

+ ]);

chrome.tabs.update(tabId, {

url: URL_MAIN + '?' + config.testServer.port