Refactor the implementation of the webNavigation extension API.

chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js

Index: chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js
diff --git a/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js b/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js
index 8097753af2ac58869ebcb95fb44e6af1888f06c6..0fc0dd3237394348774832df888a7d41415310ae 100644
--- a/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js
+++ b/chrome/test/data/extensions/api_test/webnavigation/crossProcessFragment/test_crossProcessFragment.js
@@ -12,6 +12,7 @@ onload = function() {
         return url.replace(/PORT/g, config.testServer.port);
       };
       URL_TEST = fixPort(URL_TEST);
+      let areExtensionsIsolated = config.isolateExtensions;

[Devlin, 2016/02/05 18:30:28]

I could have sworn let only worked with "use strict";.  Maybe I'm
misremembering?

[nasko, 2016/02/05 23:41:22]

Tends to work and I copied it from other places we use this statement. I could
switch it to use var, it won't change much. I usually like to keep things the
same when I copy/paste, so it can be easily grepped for in the future.

 
       chrome.test.runTests([
         // Navigates to a different site, but then modifies the reference
@@ -22,7 +23,7 @@ onload = function() {
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: getURL('f.html') }},
@@ -62,7 +63,7 @@ onload = function() {
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 1,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "3" }},
@@ -107,7 +108,7 @@ onload = function() {
               event: "onBeforeNavigate",
               details: { frameId: 0,
                          parentFrameId: -1,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: getURL('g.html') }},
@@ -147,14 +148,14 @@ onload = function() {
               event: "onBeforeNavigate",
               details: { frameId: 1,
                          parentFrameId: 0,
-                         processId: 0,
+                         processId: -1,
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }},
             { label: "b-onCommitted",
               event: "onCommitted",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          transitionQualifiers: [],
@@ -163,14 +164,14 @@ onload = function() {
             { label: "b-onDOMContentLoaded",
               event: "onDOMContentLoaded",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }},
             { label: "b-onCompleted",
               event: "onCompleted",
               details: { frameId: 1,
-                         processId: 0,
+                         processId: (areExtensionsIsolated ? 1 : 0),
                          tabId: 0,
                          timeStamp: 0,
                          url: URL_TEST + "4" }}],