Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: google_apis/gcm/gcm_client.h

Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js ('K') | « chrome/test/data/extensions/api_test/gcm/functions/send_message_data/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/gcm_client.h
diff --git a/google_apis/gcm/gcm_client.h b/google_apis/gcm/gcm_client.h
index 02a243b493e7189524c24b07d6f8e94832a4611e..77dd7ff63ee5d00b6b15261a8395f76406b5cdd6 100644
--- a/google_apis/gcm/gcm_client.h
+++ b/google_apis/gcm/gcm_client.h
@@ -40,6 +40,8 @@ class GCM_EXPORT GCMClient {
INVALID_PARAMETER,
// Profile not signed in.
NOT_SIGNED_IN,
+ // Key was missing in the manifest. The register operation requires a key.
+ MANIFEST_KEY_MISSING,
fgorski 2014/02/14 22:34:28 I am a little sceptical about putting it here, as
jianli 2014/02/14 22:47:26 Done.
// Previous asynchronous operation is still pending to finish. Certain
// operation, like register, is only allowed one at a time.
ASYNC_OPERATION_PENDING,
« chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js ('K') | « chrome/test/data/extensions/api_test/gcm/functions/send_message_data/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698