Enforce LinkedReference.dependency == 0 for contained entities.

Enforce LinkedReference.dependency == 0 for contained entities.

This was always the intention, but it didn't wind up getting
implemented as intended due to lack of testing.  This CL adds testing
and fixes the implementation.

Note that there is no effect on resynthesis, since resynthesis only
consults LinkedReference.dependency for top level entities.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1995031845b3acd9db3af845e549052eb31b1b50

[Paul Berry, 2016-02-05 21:10:27]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-05 21:15:13]

LGTM

https://codereview.chromium.org/1670353002/diff/20001/pkg/analyzer/test/src/s...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1670353002/diff/20001/pkg/analyzer/test/src/s...
pkg/analyzer/test/src/summary/summary_common.dart:5395: case
ReferenceKind.typedef:
The list of case(s) is almost sorted.
Maybe worth to move "typedef" after "topLevelFunction".

[Paul Berry, 2016-02-05 21:19:17]

https://codereview.chromium.org/1670353002/diff/20001/pkg/analyzer/test/src/s...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1670353002/diff/20001/pkg/analyzer/test/src/s...
pkg/analyzer/test/src/summary/summary_common.dart:5395: case
ReferenceKind.typedef:
On 2016/02/05 21:15:13, scheglov wrote:
> The list of case(s) is almost sorted.
> Maybe worth to move "typedef" after "topLevelFunction".

Done.

[Paul Berry, 2016-02-05 21:19:55]

Description was changed from

==========
Enforce LinkedReference.dependency == 0 for contained entities.

This was always the intention, but it didn't wind up getting
implemented as intended due to lack of testing.  This CL adds testing
and fixes the implementation.

Note that there is no effect on resynthesis, since resynthesis only
consults LinkedReference.dependency for top level entities.
==========

to

==========
Enforce LinkedReference.dependency == 0 for contained entities.

This was always the intention, but it didn't wind up getting
implemented as intended due to lack of testing.  This CL adds testing
and fixes the implementation.

Note that there is no effect on resynthesis, since resynthesis only
consults LinkedReference.dependency for top level entities.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1995031845b3acd9db3af845e549052eb31b1b50
==========

[Paul Berry, 2016-02-05 21:19:57]

Committed patchset #2 (id:20001) manually as
1995031845b3acd9db3af845e549052eb31b1b50 (presubmit successful).