Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_elements.dart

Issue 1670353002: Enforce LinkedReference.dependency == 0 for contained entities. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add a switch case to clarify. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_elements.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_elements.dart b/pkg/analyzer/lib/src/summary/summarize_elements.dart
index 7b949c07b4bfe1f3894de67d9aeee2cb2d2cc3be..4c4f6db0e4d4acfa3f36458ff8ecab7c7bc96e4d 100644
--- a/pkg/analyzer/lib/src/summary/summarize_elements.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_elements.dart
@@ -838,11 +838,15 @@ class _CompilationUnitSerializer {
int _getElementReferenceId(Element element, {bool linked: false}) {
return referenceMap.putIfAbsent(element, () {
- LibraryElement dependentLibrary = element?.library;
+ LibraryElement dependentLibrary;
+ if (element != null) {
+ Element enclosingElement = element.enclosingElement;
+ if (enclosingElement is CompilationUnitElement) {
+ dependentLibrary = enclosingElement.library;
+ }
+ }
int unit;
if (dependentLibrary == null) {
- assert(element == librarySerializer.typeProvider.dynamicType.element ||
- element == null);
unit = 0;
dependentLibrary = librarySerializer.libraryElement;
} else {
@@ -928,7 +932,6 @@ class _ConstExprSerializer extends AbstractConstExprSerializer {
int refId = serializer.linkedReferences.length;
serializer.linkedReferences.add(new LinkedReferenceBuilder(
kind: ReferenceKind.constructor,
- dependency: typeLinkedRef.dependency,
unit: typeLinkedRef.unit));
return new EntityRefBuilder(
reference: refId, typeArguments: typeRef.typeArguments);

Powered by Google App Engine
This is Rietveld 408576698