[StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl

chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

Index: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
diff --git a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
index 7e71717039abecef34060ba44bf035995f1c484f..857803b51e1411080c8e77544fe50f59226a3151 100644
--- a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
+++ b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
@@ -184,7 +184,9 @@ class MTPDeviceDelegateImplMacTest : public testing::Test {
         content::BrowserThread::IO));
     ASSERT_TRUE(io_thread_->Start());
 
-    manager_.SetNotifications(monitor_.receiver());
+    chrome::test::TestStorageMonitor* monitor =

[vandebo (ex-Chrome), 2013/07/10 16:57:45]

Is this a memory leak?

[Greg Billock, 2013/07/10 21:11:16]

No. The Create method sets it up owned by the browser process. (You sure those
ownership comments are unneeded :-))

[vandebo (ex-Chrome), 2013/07/11 15:53:00]

The new name helps some, but a Create method that returns the thing created
implies that the caller is responsible for cleaning up the thing.  Now that I
understand (again?) it's ok.  If you think it'd be an improvement though, you
might want to make the create method return void and have a seperate Get method.

[Greg Billock, 2013/07/11 20:53:35]

That's definitely a confusion. It's a test helper, so I think it's nice for it
to just do what we usually want. I'll change the name if we can come up with a
better one. Just "install"?

+        chrome::test::TestStorageMonitor::Create();
+    manager_.SetNotifications(monitor->receiver());
 
     camera_ = [MockMTPICCameraDevice alloc];
     id<ICDeviceBrowserDelegate> delegate = manager_.device_browser();
@@ -304,7 +306,6 @@ class MTPDeviceDelegateImplMacTest : public testing::Test {
   scoped_ptr<content::TestBrowserThread> file_thread_;
   scoped_ptr<content::TestBrowserThread> io_thread_;
   base::ScopedTempDir temp_dir_;
-  chrome::test::TestStorageMonitor monitor_;
   chrome::ImageCaptureDeviceManager manager_;
   MockMTPICCameraDevice* camera_;