[StorageMonitor] Move StorageMonitor ownership to BrowserProcessImpl

chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 #import <ImageCaptureCore/ImageCaptureCore.h>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/mac/cocoa_protocols.h"
@@ skipping 166 matching lines @@
 
   virtual void SetUp() OVERRIDE {
     ui_thread_.reset(new content::TestBrowserThread(
         content::BrowserThread::UI, &message_loop_));
     file_thread_.reset(new content::TestBrowserThread(
         content::BrowserThread::FILE, &message_loop_));
     io_thread_.reset(new content::TestBrowserThread(
         content::BrowserThread::IO));
     ASSERT_TRUE(io_thread_->Start());
 
-    manager_.SetNotifications(monitor_.receiver());
+    chrome::test::TestStorageMonitor* monitor =

[vandebo (ex-Chrome), 2013/07/10 16:57:45]

Is this a memory leak?

[Greg Billock, 2013/07/10 21:11:16]

No. The Create method sets it up owned by the browser process. (You sure those
ownership comments are unneeded :-))

[vandebo (ex-Chrome), 2013/07/11 15:53:00]

The new name helps some, but a Create method that returns the thing created
implies that the caller is responsible for cleaning up the thing.  Now that I
understand (again?) it's ok.  If you think it'd be an improvement though, you
might want to make the create method return void and have a seperate Get method.

[Greg Billock, 2013/07/11 20:53:35]

That's definitely a confusion. It's a test helper, so I think it's nice for it
to just do what we usually want. I'll change the name if we can come up with a
better one. Just "install"?

+        chrome::test::TestStorageMonitor::Create();
+    manager_.SetNotifications(monitor->receiver());
 
     camera_ = [MockMTPICCameraDevice alloc];
     id<ICDeviceBrowserDelegate> delegate = manager_.device_browser();
     [delegate deviceBrowser:nil didAddDevice:camera_ moreComing:NO];
 
     delegate_ = new chrome::MTPDeviceDelegateImplMac(kDeviceId, kDevicePath);
   }
 
   void OnError(base::WaitableEvent* event, base::PlatformFileError error) {
     error_ = error;
@@ skipping 99 matching lines @@
     io_thread_->Stop();
   }
 
  protected:
   base::MessageLoopForUI message_loop_;
   // Note: threads must be made in this order: UI > FILE > IO
   scoped_ptr<content::TestBrowserThread> ui_thread_;
   scoped_ptr<content::TestBrowserThread> file_thread_;
   scoped_ptr<content::TestBrowserThread> io_thread_;
   base::ScopedTempDir temp_dir_;
-  chrome::test::TestStorageMonitor monitor_;
   chrome::ImageCaptureDeviceManager manager_;
   MockMTPICCameraDevice* camera_;
 
   // This object needs special deletion inside the above |task_runner_|.
   chrome::MTPDeviceDelegateImplMac* delegate_;
 
   base::PlatformFileError error_;
   base::PlatformFileInfo info_;
   fileapi::AsyncFileUtil::EntryList file_list_;
 
@@ skipping 244 matching lines @@
                          temp_dir_.path().Append("target")));
 
   EXPECT_EQ(base::PLATFORM_FILE_OK,
              DownloadFile(base::FilePath("/ic:id/filename"),
                           temp_dir_.path().Append("target")));
   std::string contents;
   EXPECT_TRUE(file_util::ReadFileToString(temp_dir_.path().Append("target"),
                                           &contents));
   EXPECT_EQ(kTestFileContents, contents);
 }