Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 167013003: cc: Don't schedule top controls animation when there isn't one (Closed)

Created:
6 years, 10 months ago by Sami
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Don't schedule top controls animation when there isn't one If the top controls manager calculates an animation scroll delta of zero, we schedule another animation attempt for the following frame. This causes the compositor to run constantly -- for instance -- on pages where scrolling JavaScript-driven instead of impl-driven. The fix is to bail out if there is no active top controls animation. TEST=LayerTreeHostImplWithTopControlsTest.NoIdleAnimation BUG=309648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251770

Patch Set 1 #

Patch Set 2 : mismatch smismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sami
Looks like this bug snuck in through this patch: https://codereview.chromium.org/131373004 PTAL, thanks!
6 years, 10 months ago (2014-02-17 17:29:48 UTC) #1
aelias_OOO_until_Jul13
On 2014/02/17 17:29:48, Sami wrote: > Looks like this bug snuck in through this patch: ...
6 years, 10 months ago (2014-02-17 22:44:44 UTC) #2
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 10 months ago (2014-02-18 11:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/167013003/40001
6 years, 10 months ago (2014-02-18 11:16:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 12:56:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265519
6 years, 10 months ago (2014-02-18 12:56:23 UTC) #6
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 10 months ago (2014-02-18 12:59:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/167013003/40001
6 years, 10 months ago (2014-02-18 13:00:14 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:31:10 UTC) #9
Message was sent while issue was closed.
Change committed as 251770

Powered by Google App Engine
This is Rietveld 408576698