Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 1669983003: [Contextual Search] Fixes flaky test. (Closed)

Created:
4 years, 10 months ago by pedro (no code reviews)
Modified:
4 years, 10 months ago
Reviewers:
Theresa, Donn Denman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fixes and re-enables ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm. Sometimes, the test tries to check the search term before the URL has started loading, which ends up resulting in failing to match the search term. The empty URL could also cause a crash when running the test, so this CL fixes the problem by waiting for the URL to match the search term, and also checks if the URL is null to prevent crashes. BUG=551711 Committed: https://crrev.com/938110aa31eef055669b539990d7f87336b57633 Cr-Commit-Position: refs/heads/master@{#373889}

Patch Set 1 #

Patch Set 2 : Sync & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 5 chunks +18 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
pedro (no code reviews)
Theresa and Donn, please take a look at this change.
4 years, 10 months ago (2016-02-05 18:35:28 UTC) #3
Theresa
lgtm Can you make the commit message more descriptive, e.g. "Fixes and re-enables ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm"
4 years, 10 months ago (2016-02-05 18:47:42 UTC) #4
Donn Denman
lgtm
4 years, 10 months ago (2016-02-05 19:05:23 UTC) #5
Donn Denman
lgtm
4 years, 10 months ago (2016-02-05 19:05:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669983003/20001
4 years, 10 months ago (2016-02-05 19:30:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 20:10:11 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/938110aa31eef055669b539990d7f87336b57633 Cr-Commit-Position: refs/heads/master@{#373889}
4 years, 10 months ago (2016-02-05 20:24:19 UTC) #15
pedro (no code reviews)
4 years, 10 months ago (2016-02-05 23:45:36 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1678573002/ by pedrosimonetti@chromium.org.

The reason for reverting is: Reverting it, since it's making some bots to
crash..

Powered by Google App Engine
This is Rietveld 408576698