[Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/

[Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
Committed: https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe
Cr-Commit-Position: refs/heads/master@{#374531}

[pedro (no code reviews), 2016-02-09 19:39:22]

Description was changed from

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
==========

to

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
==========

[pedro (no code reviews), 2016-02-09 19:39:22]

pedrosimonetti@chromium.org changed reviewers:
+ mdjones@chromium.org

[pedro (no code reviews), 2016-02-09 19:39:31]

Matt, PTAL

[mdjones, 2016-02-09 19:41:47]

rs lgtm. Consider making this test similar to those in
ContextualSearchTapEventTest.

[pedro (no code reviews), 2016-02-09 20:45:08]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2016-02-09 20:45:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org
Link to the patchset: https://codereview.chromium.org/1685763003/#ps40001
(title: "Sync")

[commit-bot: I haz the power, 2016-02-09 20:48:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685763003/40001

[pedro (no code reviews), 2016-02-09 22:35:31]

The CQ bit was unchecked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2016-02-09 22:35:32]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2016-02-09 22:35:49]

The CQ bit was unchecked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2016-02-09 22:36:09]

The CQ bit was checked by pedrosimonetti@chromium.org

[commit-bot: I haz the power, 2016-02-09 22:38:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685763003/40001

[commit-bot: I haz the power, 2016-02-09 23:38:40]

Description was changed from

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
==========

to

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
==========

[commit-bot: I haz the power, 2016-02-09 23:38:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-09 23:40:17]

Description was changed from

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711
==========

to

==========
[Contextual Search] Re-landing the CL:
https://codereview.chromium.org/1669983003/

Fixes and re-enables
ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.

Sometimes, the test tries to check the search term before
the URL has started loading, which ends up resulting in
failing to match the search term. The empty URL could also
cause a crash when running the test, so this CL fixes the
problem by waiting for the URL to match the search term,
and also checks if the URL is null to prevent crashes.

BUG=551711

Committed: https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe
Cr-Commit-Position: refs/heads/master@{#374531}
==========

[commit-bot: I haz the power, 2016-02-09 23:40:17]

Patchset 3 (id:??) landed as
https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe
Cr-Commit-Position: refs/heads/master@{#374531}

[blundell, 2016-02-10 11:52:33]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1683083002/ by blundell@chromium.org.

The reason for reverting is: Test crashes flakily (e.g.,
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/2...).
I would attach a snippet of output from the crash, but there is no useful output
that I can see..