Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1669683002: styleguide: Fix/clarify the cbegin/cend rules are for container methods (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
Nico, jbroman
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, Peter Kasting, vmpstr+watch_chromium.org, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

styleguide: Fix/clarify the cbegin/cend rules are for container methods Not for the global std::cbegin/cend, which are in C++14. R=Nico, jbroman Committed: https://crrev.com/d18d3a0518340523ba3178c8038618823d138a57 Cr-Commit-Position: refs/heads/master@{#373604}

Patch Set 1 #

Patch Set 2 : cbegin: . #

Total comments: 2

Patch Set 3 : cbegin: upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M styleguide/c++/c++11.html View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
4 years, 10 months ago (2016-02-03 23:55:43 UTC) #1
Nico
lgtm, thansk
4 years, 10 months ago (2016-02-04 15:50:59 UTC) #2
jbroman
https://codereview.chromium.org/1669683002/diff/20001/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1669683002/diff/20001/tools/clang/scripts/update.py#newcode541 tools/clang/scripts/update.py:541: cflags += ['-g -O0 -fno-strict-aliasing'] This doesn't seem related ...
4 years, 10 months ago (2016-02-04 16:50:49 UTC) #3
danakj
https://codereview.chromium.org/1669683002/diff/20001/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1669683002/diff/20001/tools/clang/scripts/update.py#newcode541 tools/clang/scripts/update.py:541: cflags += ['-g -O0 -fno-strict-aliasing'] On 2016/02/04 16:50:48, jbroman ...
4 years, 10 months ago (2016-02-04 19:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669683002/40001
4 years, 10 months ago (2016-02-04 19:52:11 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 20:28:26 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 20:29:32 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d18d3a0518340523ba3178c8038618823d138a57
Cr-Commit-Position: refs/heads/master@{#373604}

Powered by Google App Engine
This is Rietveld 408576698