Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: tools/clang/scripts/update.py

Issue 1669683002: styleguide: Fix/clarify the cbegin/cend rules are for container methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cbegin: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « styleguide/c++/c++11.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """This script is used to download prebuilt clang binaries. 6 """This script is used to download prebuilt clang binaries.
7 7
8 It is also used by package.py to build the prebuilt clang binaries.""" 8 It is also used by package.py to build the prebuilt clang binaries."""
9 9
10 import argparse 10 import argparse
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 binutils_incdir = '' 531 binutils_incdir = ''
532 if sys.platform.startswith('linux'): 532 if sys.platform.startswith('linux'):
533 binutils_incdir = os.path.join(BINUTILS_DIR, 'Linux_x64/Release/include') 533 binutils_incdir = os.path.join(BINUTILS_DIR, 'Linux_x64/Release/include')
534 534
535 # If building at head, define a macro that plugins can use for #ifdefing 535 # If building at head, define a macro that plugins can use for #ifdefing
536 # out code that builds at head, but not at CLANG_REVISION or vice versa. 536 # out code that builds at head, but not at CLANG_REVISION or vice versa.
537 if use_head_revision: 537 if use_head_revision:
538 cflags += ['-DLLVM_FORCE_HEAD_REVISION'] 538 cflags += ['-DLLVM_FORCE_HEAD_REVISION']
539 cxxflags += ['-DLLVM_FORCE_HEAD_REVISION'] 539 cxxflags += ['-DLLVM_FORCE_HEAD_REVISION']
540 540
541 cflags += ['-g -O0 -fno-strict-aliasing']
jbroman 2016/02/04 16:50:48 This doesn't seem related to this change?
danakj 2016/02/04 19:50:11 Ooops :3 Upload fail.
542
541 CreateChromeToolsShim() 543 CreateChromeToolsShim()
542 544
543 deployment_env = None 545 deployment_env = None
544 if deployment_target: 546 if deployment_target:
545 deployment_env = os.environ.copy() 547 deployment_env = os.environ.copy()
546 deployment_env['MACOSX_DEPLOYMENT_TARGET'] = deployment_target 548 deployment_env['MACOSX_DEPLOYMENT_TARGET'] = deployment_target
547 549
548 cmake_args = [] 550 cmake_args = []
549 # TODO(thakis): Unconditionally append this to base_cmake_args instead once 551 # TODO(thakis): Unconditionally append this to base_cmake_args instead once
550 # compiler-rt can build with clang-cl on Windows (http://llvm.org/PR23698) 552 # compiler-rt can build with clang-cl on Windows (http://llvm.org/PR23698)
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 args.force_local_build = True 812 args.force_local_build = True
811 if 'OS=android' not in os.environ.get('GYP_DEFINES', ''): 813 if 'OS=android' not in os.environ.get('GYP_DEFINES', ''):
812 # Only build the Android ASan rt on ToT bots when targetting Android. 814 # Only build the Android ASan rt on ToT bots when targetting Android.
813 args.with_android = False 815 args.with_android = False
814 816
815 return UpdateClang(args) 817 return UpdateClang(args)
816 818
817 819
818 if __name__ == '__main__': 820 if __name__ == '__main__':
819 sys.exit(main()) 821 sys.exit(main())
OLDNEW
« no previous file with comments | « styleguide/c++/c++11.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698