chrome/test/chromedriver/element_commands.h - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/element_commands.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DEPS modifications. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/navigation_tracker.cc ('K') | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/element_commands.h

diff --git a/chrome/test/chromedriver/element_commands.h b/chrome/test/chromedriver/element_commands.h

index 146f28afca198037f15f063994a8fa311da370b2..68cd197b910fdf03c2f0a1a7d7a1c1037e67b1cf 100644

--- a/chrome/test/chromedriver/element_commands.h

+++ b/chrome/test/chromedriver/element_commands.h

@@ -17,6 +17,7 @@ class Value;

struct Session;

class Status;

+class Timeout;

class WebView;

typedef base::Callback<Status(

@@ -32,7 +33,8 @@ Status ExecuteElementCommand(

Session* session,

WebView* web_view,

const base::DictionaryValue& params,

- scoped_ptr<base::Value>* value);

+ scoped_ptr<base::Value>* value,

+ Timeout* timeout);

// Search for an element on the page, starting from the given element.

Status ExecuteFindChildElement(