Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove DEPS modifications. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/element_commands.cc
diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc
index 7224d5ecada206e3c6ece57559bb500f5bb82464..13ab02f00c8721ce5ea254decffea47d0dbef1df 100644
--- a/chrome/test/chromedriver/element_commands.cc
+++ b/chrome/test/chromedriver/element_commands.cc
@@ -85,7 +85,8 @@ Status ExecuteElementCommand(
Session* session,
WebView* web_view,
const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value) {
+ scoped_ptr<base::Value>* value,
+ Timeout* timeout) {
std::string id;
if (params.GetString("id", &id) || params.GetString("element", &id))
return command.Run(session, web_view, id, params, value);

Powered by Google App Engine
This is Rietveld 408576698