Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/element_commands.h ('k') | chrome/test/chromedriver/net/sync_websocket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_commands.cc
diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc
index 9061884901a56fd2dfd39310a8e92f81d6c97b7b..a39b7333517e1704f0739aa7444323f82bd5bedb 100644
--- a/chrome/test/chromedriver/element_commands.cc
+++ b/chrome/test/chromedriver/element_commands.cc
@@ -80,11 +80,13 @@ Status SendKeysToElement(
} // namespace
-Status ExecuteElementCommand(const ElementCommand& command,
- Session* session,
- WebView* web_view,
- const base::DictionaryValue& params,
- std::unique_ptr<base::Value>* value) {
+Status ExecuteElementCommand(
+ const ElementCommand& command,
+ Session* session,
+ WebView* web_view,
+ const base::DictionaryValue& params,
+ std::unique_ptr<base::Value>* value,
+ Timeout* timeout) {
std::string id;
if (params.GetString("id", &id) || params.GetString("element", &id))
return command.Run(session, web_view, id, params, value);
« no previous file with comments | « chrome/test/chromedriver/element_commands.h ('k') | chrome/test/chromedriver/net/sync_websocket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698