Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7035)

Unified Diff: chrome/test/chromedriver/chrome/stub_devtools_client.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/stub_devtools_client.h
diff --git a/chrome/test/chromedriver/chrome/stub_devtools_client.h b/chrome/test/chromedriver/chrome/stub_devtools_client.h
index 4b0ca676381eaca3ddb3052fd6769c60352c96b4..e405e7f38cb190d2d146a070c05f872c0184a146 100644
--- a/chrome/test/chromedriver/chrome/stub_devtools_client.h
+++ b/chrome/test/chromedriver/chrome/stub_devtools_client.h
@@ -31,6 +31,10 @@ class StubDevToolsClient : public DevToolsClient {
Status SendCommand(
const std::string& method,
const base::DictionaryValue& params) override;
+ Status SendCommandWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout) override;
Status SendAsyncCommand(
const std::string& method,
const base::DictionaryValue& params) override;
@@ -38,9 +42,14 @@ class StubDevToolsClient : public DevToolsClient {
const std::string& method,
const base::DictionaryValue& params,
std::unique_ptr<base::DictionaryValue>* result) override;
+ Status SendCommandAndGetResultWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout,
+ std::unique_ptr<base::DictionaryValue>* result) override;
void AddListener(DevToolsEventListener* listener) override;
Status HandleEventsUntil(const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) override;
+ const Timeout& timeout) override;
Status HandleReceivedEvents() override;
protected:

Powered by Google App Engine
This is Rietveld 408576698