Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc b/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
index cf9eeaec8292a48ff42755d683cc9736a95b3658..699e437071a054c7cc2c9cc7252999623181e053 100644
--- a/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
+++ b/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
@@ -20,7 +20,8 @@ void AssertPendingState(NavigationTracker* tracker,
const std::string& frame_id,
bool expected_is_pending) {
bool is_pending = !expected_is_pending;
- ASSERT_EQ(kOk, tracker->IsPendingNavigation(frame_id, &is_pending).code());
+ ASSERT_EQ(
+ kOk, tracker->IsPendingNavigation(frame_id, nullptr, &is_pending).code());
ASSERT_EQ(expected_is_pending, is_pending);
}
@@ -326,7 +327,7 @@ TEST(NavigationTracker, UnknownStateFailsToDetermineState) {
NavigationTracker tracker(&client, &browser_info, &dialog_manager);
bool is_pending;
ASSERT_EQ(kUnknownError,
- tracker.IsPendingNavigation("f", &is_pending).code());
+ tracker.IsPendingNavigation("f", nullptr, &is_pending).code());
}
TEST(NavigationTracker, UnknownStatePageNotLoadAtAll) {
« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker.cc ('k') | chrome/test/chromedriver/chrome/stub_devtools_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698