Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/test/chromedriver/chrome/stub_devtools_client.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/stub_devtools_client.cc
diff --git a/chrome/test/chromedriver/chrome/stub_devtools_client.cc b/chrome/test/chromedriver/chrome/stub_devtools_client.cc
index 4e93ff0a707745d3a4ee56b0e653518e4560ea66..288464682ebc4be13ab482e619d82b6a12922e68 100644
--- a/chrome/test/chromedriver/chrome/stub_devtools_client.cc
+++ b/chrome/test/chromedriver/chrome/stub_devtools_client.cc
@@ -32,6 +32,13 @@ Status StubDevToolsClient::SendCommand(
return SendCommandAndGetResult(method, params, &result);
}
+Status StubDevToolsClient::SendCommandWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout) {
+ return SendCommand(method, params);
+}
+
Status StubDevToolsClient::SendAsyncCommand(
const std::string& method,
const base::DictionaryValue& params) {
@@ -46,13 +53,21 @@ Status StubDevToolsClient::SendCommandAndGetResult(
return Status(kOk);
}
+Status StubDevToolsClient::SendCommandAndGetResultWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout,
+ std::unique_ptr<base::DictionaryValue>* result) {
+ return SendCommandAndGetResult(method, params, result);
+}
+
void StubDevToolsClient::AddListener(DevToolsEventListener* listener) {
listeners_.push_back(listener);
}
Status StubDevToolsClient::HandleEventsUntil(
const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) {
+ const Timeout& timeout) {
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_devtools_client.h ('k') | chrome/test/chromedriver/chrome/stub_web_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698