Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/test/chromedriver/util.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/util.h
diff --git a/chrome/test/chromedriver/util.h b/chrome/test/chromedriver/util.h
index 111ced481670aaaf8a445b955879085302adac39..ef75b2be6a63ff3d82944b9db7b8471998943548 100644
--- a/chrome/test/chromedriver/util.h
+++ b/chrome/test/chromedriver/util.h
@@ -7,6 +7,8 @@
#include <string>
+#include "base/time/time.h"
+
namespace base {
class FilePath;
class ListValue;
@@ -16,6 +18,42 @@ struct Session;
class Status;
class WebView;
+// A helper for tracking the time spent executing a task. Creating a new
+// instance marks the beginning of the task. Task duration limit may be set
+// in the contructor or at any time later, but only once.
+class Timeout {
+ public:
+ Timeout();
+ explicit Timeout(const base::TimeDelta& duration);
+
+ // To be used when executing a sub-task with its own timeout, keeping track
+ // of the parent task timeout at the same time. Creates a new Timeout whose
+ // deadline is either Now() + |duration| or deadline of |outer|, whichever is
+ // smaller. |outer| may be nullptr. Note: setting duration on |outer| won't
+ // affect sub-timeouts that were created earlier!
+ Timeout(const base::TimeDelta& duration, const Timeout* outer);
+
+ // Sets the deadline by adding |duration| to the start time recored at
+ // contruction. Should not be called if the deadline is already set.
+ void SetDuration(const base::TimeDelta& duration);
+
+ bool is_set() const { return !deadline_.is_null(); }
+
+ // Whether the remaining time delta is less than or equal to zero.
+ bool IsExpired() const;
+
+ // Returns the duration if set, otherwise returns TimeDelta::Max().
+ base::TimeDelta GetDuration() const;
+
+ // Returns the remaining time if duration is set, otherwise returns
+ // TimeDelta::Max().
+ base::TimeDelta GetRemainingTime() const;
+
+ private:
+ base::TimeTicks start_;
+ base::TimeTicks deadline_;
+};
+
// Generates a random, 32-character hexidecimal ID.
std::string GenerateId();

Powered by Google App Engine
This is Rietveld 408576698