Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10740)

Unified Diff: chrome/test/chromedriver/test/webserver.py

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/test/webserver.py
diff --git a/chrome/test/chromedriver/test/webserver.py b/chrome/test/chromedriver/test/webserver.py
index f19f38f9c5d203d816c57883ea1aef1edb2fcff9..a5a5d321014aa2bea6dcdbbd2e19baed6a14cae0 100644
--- a/chrome/test/chromedriver/test/webserver.py
+++ b/chrome/test/chromedriver/test/webserver.py
@@ -5,6 +5,7 @@
import BaseHTTPServer
import os
import threading
+import sys
class Responder(object):
@@ -80,6 +81,18 @@ class _BaseServer(BaseHTTPServer.HTTPServer):
"""Overriddes base class method to disable logging."""
pass
+ def handle(self):
+ try:
+ BaseHTTPServer.BaseHTTPRequestHandler.handle(self)
+ except:
+ pass # Ignore socket errors.
+
+ def finish(self):
+ try:
+ BaseHTTPServer.BaseHTTPRequestHandler.finish(self)
+ except:
+ pass # Ignore socket errors.
+
BaseHTTPServer.HTTPServer.__init__(self, ('127.0.0.1', 0), _Handler)
if server_cert_and_key_path is not None:
@@ -94,9 +107,9 @@ class _BaseServer(BaseHTTPServer.HTTPServer):
"""Overridden from SocketServer."""
raise RuntimeError('Timed out waiting for http request')
- def GetUrl(self):
+ def GetUrl(self, host=None):
"""Returns the base URL of the server."""
- postfix = '://127.0.0.1:%s' % self.server_port
+ postfix = '://%s:%s' % (host or '127.0.0.1', self.server_port)
if self._is_https_enabled:
return 'https' + postfix
return 'http' + postfix
@@ -174,9 +187,9 @@ class WebServer(object):
self._path_maps_lock.release()
- def GetUrl(self):
+ def GetUrl(self, host=None):
"""Returns the base URL of the server."""
- return self._server.GetUrl()
+ return self._server.GetUrl(host)
def Shutdown(self):
"""Shuts down the server synchronously."""
@@ -223,5 +236,5 @@ class SyncWebServer(object):
responder.SendResponse({}, content)
self.Respond(SendContent)
- def GetUrl(self):
- return self._server.GetUrl()
+ def GetUrl(self, host=None):
+ return self._server.GetUrl(host)

Powered by Google App Engine
This is Rietveld 408576698