chrome/test/chromedriver/net/sync_websocket_impl.h - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client.cc ('K') | « chrome/test/chromedriver/net/sync_websocket.h ('k') | chrome/test/chromedriver/net/sync_websocket_impl.cc » ('j') | chrome/test/chromedriver/util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/net/sync_websocket_impl.h

diff --git a/chrome/test/chromedriver/net/sync_websocket_impl.h b/chrome/test/chromedriver/net/sync_websocket_impl.h

index 5bef09497407518588252b0c3206d69075831a8f..d667a7bba90ccc3d994e43fcbb88f63b301a1455 100644

--- a/chrome/test/chromedriver/net/sync_websocket_impl.h

+++ b/chrome/test/chromedriver/net/sync_websocket_impl.h

@@ -37,7 +37,7 @@ class SyncWebSocketImpl : public SyncWebSocket {

bool Connect(const GURL& url) override;

bool Send(const std::string& message) override;

StatusCode ReceiveNextMessage(std::string* message,

- const base::TimeDelta& timeout) override;

+ const Timeout& timeout) override;

bool HasNextMessage() override;

private:

@@ -52,7 +52,7 @@ class SyncWebSocketImpl : public SyncWebSocket {

bool Send(const std::string& message);

SyncWebSocket::StatusCode ReceiveNextMessage(

std::string* message,

- const base::TimeDelta& timeout);

+ const Timeout& timeout);

bool HasNextMessage();

// Overriden from WebSocketListener: