chrome/test/chromedriver/net/sync_websocket.h - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/sync_websocket.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client.cc ('K') | « chrome/test/chromedriver/net/DEPS ('k') | chrome/test/chromedriver/net/sync_websocket_impl.h » ('j') | chrome/test/chromedriver/util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/net/sync_websocket.h

diff --git a/chrome/test/chromedriver/net/sync_websocket.h b/chrome/test/chromedriver/net/sync_websocket.h

index 5dd59da54446fd72fbb336f17924f190fbd88458..d5833ff1f9bb32ae44a262a0719beae927416805 100644

--- a/chrome/test/chromedriver/net/sync_websocket.h

+++ b/chrome/test/chromedriver/net/sync_websocket.h

@@ -7,9 +7,8 @@

#include <string>

-#include "base/time/time.h"

class GURL;

+class Timeout;

// Proxy for using a WebSocket running on a background thread synchronously.

class SyncWebSocket {

@@ -36,7 +35,7 @@ class SyncWebSocket {

// Returns StatusCode::kDisconnected if the socket is closed.

virtual StatusCode ReceiveNextMessage(

std::string* message,

- const base::TimeDelta& timeout) = 0;

+ const Timeout& timeout) = 0;

// Returns whether there are any messages that have been received and not yet

// handled by ReceiveNextMessage.