chrome/test/chromedriver/chrome/navigation_tracker.h - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client.cc ('K') | « chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('k') | chrome/test/chromedriver/chrome/navigation_tracker.cc » ('j') | chrome/test/chromedriver/util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/navigation_tracker.h

diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.h b/chrome/test/chromedriver/chrome/navigation_tracker.h

index b48dad44aa1eba3f08399e8bfe49350970fa26cb..6ad94105f8972687ca67ca3e8df9aebe9add9533 100644

--- a/chrome/test/chromedriver/chrome/navigation_tracker.h

+++ b/chrome/test/chromedriver/chrome/navigation_tracker.h

@@ -21,6 +21,7 @@ class DictionaryValue;

struct BrowserInfo;

class DevToolsClient;

class Status;

+class Timeout;

// Tracks the navigation state of the page.

class NavigationTracker : public DevToolsEventListener {

@@ -41,7 +42,9 @@ class NavigationTracker : public DevToolsEventListener {

// Gets whether a navigation is pending for the specified frame. |frame_id|

// may be empty to signify the main frame.

- Status IsPendingNavigation(const std::string& frame_id, bool* is_pending);

+ Status IsPendingNavigation(const std::string& frame_id,

+ const Timeout* timeout,

+ bool* is_pending);

void set_timed_out(bool timed_out);