| Index: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
|
| diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
|
| index fb70d8d1bc61c136f58f2d7d749c13f9c4bc519b..765fc2703fb50bfece4f6e24d65d99e0260a4108 100644
|
| --- a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
|
| +++ b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
|
| @@ -17,6 +17,7 @@
|
| #include "chrome/test/chromedriver/chrome/status.h"
|
| #include "chrome/test/chromedriver/net/sync_websocket.h"
|
| #include "chrome/test/chromedriver/net/sync_websocket_factory.h"
|
| +#include "chrome/test/chromedriver/util.h"
|
| #include "testing/gtest/include/gtest/gtest.h"
|
| #include "url/gurl.h"
|
|
|
| @@ -62,8 +63,8 @@ class MockSyncWebSocket : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| - if (timeout <= base::TimeDelta())
|
| + const Timeout& timeout) override {
|
| + if (timeout.IsExpired())
|
| return SyncWebSocket::kTimeout;
|
| base::DictionaryValue response;
|
| response.SetInteger("id", id_);
|
| @@ -142,7 +143,7 @@ class MockSyncWebSocket2 : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| EXPECT_TRUE(false);
|
| return SyncWebSocket::kDisconnected;
|
| }
|
| @@ -178,7 +179,7 @@ class MockSyncWebSocket3 : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| EXPECT_TRUE(false);
|
| return SyncWebSocket::kDisconnected;
|
| }
|
| @@ -219,7 +220,7 @@ class MockSyncWebSocket4 : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| return SyncWebSocket::kDisconnected;
|
| }
|
|
|
| @@ -260,7 +261,7 @@ class FakeSyncWebSocket : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| return SyncWebSocket::kOk;
|
| }
|
|
|
| @@ -581,7 +582,7 @@ TEST_F(DevToolsClientImplTest, HandleEventsUntil) {
|
| client.AddListener(&listener);
|
| ASSERT_EQ(kOk, client.ConnectIfNecessary().code());
|
| Status status = client.HandleEventsUntil(base::Bind(&AlwaysTrue),
|
| - long_timeout_);
|
| + Timeout(long_timeout_));
|
| ASSERT_EQ(kOk, status.code());
|
| }
|
|
|
| @@ -593,7 +594,7 @@ TEST_F(DevToolsClientImplTest, HandleEventsUntilTimeout) {
|
| base::Bind(&ReturnEvent));
|
| ASSERT_EQ(kOk, client.ConnectIfNecessary().code());
|
| Status status = client.HandleEventsUntil(base::Bind(&AlwaysTrue),
|
| - base::TimeDelta());
|
| + Timeout(base::TimeDelta()));
|
| ASSERT_EQ(kTimeout, status.code());
|
| }
|
|
|
| @@ -605,7 +606,7 @@ TEST_F(DevToolsClientImplTest, WaitForNextEventCommand) {
|
| base::Bind(&ReturnCommand));
|
| ASSERT_EQ(kOk, client.ConnectIfNecessary().code());
|
| Status status = client.HandleEventsUntil(base::Bind(&AlwaysTrue),
|
| - long_timeout_);
|
| + Timeout(long_timeout_));
|
| ASSERT_EQ(kUnknownError, status.code());
|
| }
|
|
|
| @@ -617,7 +618,7 @@ TEST_F(DevToolsClientImplTest, WaitForNextEventError) {
|
| base::Bind(&ReturnError));
|
| ASSERT_EQ(kOk, client.ConnectIfNecessary().code());
|
| Status status = client.HandleEventsUntil(base::Bind(&AlwaysTrue),
|
| - long_timeout_);
|
| + Timeout(long_timeout_));
|
| ASSERT_EQ(kUnknownError, status.code());
|
| }
|
|
|
| @@ -629,7 +630,7 @@ TEST_F(DevToolsClientImplTest, WaitForNextEventConditionalFuncReturnsError) {
|
| base::Bind(&ReturnEvent));
|
| ASSERT_EQ(kOk, client.ConnectIfNecessary().code());
|
| Status status = client.HandleEventsUntil(base::Bind(&AlwaysError),
|
| - long_timeout_);
|
| + Timeout(long_timeout_));
|
| ASSERT_EQ(kUnknownError, status.code());
|
| }
|
|
|
| @@ -741,7 +742,7 @@ class OnConnectedSyncWebSocket : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| if (queued_response_.empty())
|
| return SyncWebSocket::kDisconnected;
|
| *message = queued_response_.front();
|
| @@ -804,7 +805,7 @@ class MockSyncWebSocket5 : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| if (request_no_ == 0) {
|
| *message = "{\"method\": \"m\", \"params\": {}}";
|
| } else {
|
| @@ -954,7 +955,7 @@ class MockSyncWebSocket6 : public SyncWebSocket {
|
|
|
| SyncWebSocket::StatusCode ReceiveNextMessage(
|
| std::string* message,
|
| - const base::TimeDelta& timeout) override {
|
| + const Timeout& timeout) override {
|
| if (messages_->empty())
|
| return SyncWebSocket::kDisconnected;
|
| *message = messages_->front();
|
|
|