chrome/test/chromedriver/chrome/DEPS - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Unified Diff: chrome/test/chromedriver/chrome/DEPS

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | chrome/test/chromedriver/chrome/devtools_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/DEPS

diff --git a/chrome/test/chromedriver/chrome/DEPS b/chrome/test/chromedriver/chrome/DEPS

index efb11fcb5d52ee0352b72d309f04b86575278456..a3c506ce828e827ddeb8d39fa103f2593527d6fc 100644

--- a/chrome/test/chromedriver/chrome/DEPS

+++ b/chrome/test/chromedriver/chrome/DEPS

@@ -6,4 +6,6 @@ include_rules = [

"+chrome/test/chromedriver/extension",

"+chrome/test/chromedriver/js",

"+chrome/test/chromedriver/net",

+ # Temporarily allow, for using Timeout.

+ "+chrome/test/chromedriver/util.h",

samuong 2016/02/19 20:18:57 how about we move the Timeout class into chrome/te

Alexander Semashko 2016/02/19 23:38:58 Initially I thought about it, but it does not seem

samuong 2016/02/20 00:11:44 I agree that it'd be better in a base directory, b

Alexander Semashko 2016/02/20 00:38:40 Ok, let's move it to /net.

Alexander Semashko 2016/02/24 12:51:20 Done.

]