chrome/test/chromedriver/chrome/DEPS - Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations

Side by Side Diff: chrome/test/chromedriver/chrome/DEPS

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | chrome/test/chromedriver/chrome/devtools_client.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # These files should not depend on chromedriver code.	2 # These files should not depend on chromedriver code.

3 "-chrome/test/chromedriver",	3 "-chrome/test/chromedriver",

4	4

5 "+chrome/test/chromedriver/chrome",	5 "+chrome/test/chromedriver/chrome",

6 "+chrome/test/chromedriver/extension",	6 "+chrome/test/chromedriver/extension",

7 "+chrome/test/chromedriver/js",	7 "+chrome/test/chromedriver/js",

8 "+chrome/test/chromedriver/net",	8 "+chrome/test/chromedriver/net",

	9 # Temporarily allow, for using Timeout.

	10 "+chrome/test/chromedriver/util.h",
	samuong 2016/02/19 20:18:57 how about we move the Timeout class into chrome/te how about we move the Timeout class into chrome/test/chromedriver/net/timeout.{cc,h}? Alexander Semashko 2016/02/19 23:38:58 Initially I thought about it, but it does not seem Show quoted text On 2016/02/19 20:18:57, samuong wrote: > how about we move the Timeout class into > chrome/test/chromedriver/net/timeout.{cc,h}? Initially I thought about it, but it does not seem a truly right way to go since this Timeout is not really a /net level concept. If there was chromedriver/base, Timeout would fit there well, but I'm not sure it's worth creating a /base dir for it. I'd accept whatever you decide, just wanted to clarify the issue. samuong 2016/02/20 00:11:44 I agree that it'd be better in a base directory, b Show quoted text On 2016/02/19 23:38:58, Alexander Semashko wrote: > On 2016/02/19 20:18:57, samuong wrote: > > how about we move the Timeout class into > > chrome/test/chromedriver/net/timeout.{cc,h}? > > Initially I thought about it, but it does not seem a truly right way to go since > this Timeout is not really a /net level concept. If there was chromedriver/base, > Timeout would fit there well, but I'm not sure it's worth creating a /base dir > for it. I'd accept whatever you decide, just wanted to clarify the issue. I agree that it'd be better in a base directory, but also agree that it's not really yet worth creating a new base directory just for this. Right now we're only using it in the context of DevTools/network requests, but if that changes we could move it out of net/ into some other higher-level directory. I just don't think we should be putting too many different things into this util file. Alexander Semashko 2016/02/20 00:38:40 Ok, let's move it to /net. Show quoted text On 2016/02/20 00:11:44, samuong wrote: > On 2016/02/19 23:38:58, Alexander Semashko wrote: > > On 2016/02/19 20:18:57, samuong wrote: > > > how about we move the Timeout class into > > > chrome/test/chromedriver/net/timeout.{cc,h}? > > > > Initially I thought about it, but it does not seem a truly right way to go > since > > this Timeout is not really a /net level concept. If there was > chromedriver/base, > > Timeout would fit there well, but I'm not sure it's worth creating a /base dir > > for it. I'd accept whatever you decide, just wanted to clarify the issue. > > I agree that it'd be better in a base directory, but also agree that it's not > really yet worth creating a new base directory just for this. Right now we're > only using it in the context of DevTools/network requests, but if that changes > we could move it out of net/ into some other higher-level directory. I just > don't think we should be putting too many different things into this util file. Ok, let's move it to /net. Alexander Semashko 2016/02/24 12:51:20 Done. Show quoted text On 2016/02/20 00:38:40, Alexander Semashko wrote: > On 2016/02/20 00:11:44, samuong wrote: > > On 2016/02/19 23:38:58, Alexander Semashko wrote: > > > On 2016/02/19 20:18:57, samuong wrote: > > > > how about we move the Timeout class into > > > > chrome/test/chromedriver/net/timeout.{cc,h}? > > > > > > Initially I thought about it, but it does not seem a truly right way to go > > since > > > this Timeout is not really a /net level concept. If there was > > chromedriver/base, > > > Timeout would fit there well, but I'm not sure it's worth creating a /base > dir > > > for it. I'd accept whatever you decide, just wanted to clarify the issue. > > > > I agree that it'd be better in a base directory, but also agree that it's not > > really yet worth creating a new base directory just for this. Right now we're > > only using it in the context of DevTools/network requests, but if that changes > > we could move it out of net/ into some other higher-level directory. I just > > don't think we should be putting too many different things into this util > file. > > Ok, let's move it to /net. Done.
9 ]	11 ]

OLD	NEW