Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceAssemblerARM32.h

Issue 1669443002: Subzero. Uses fixups to calculate addend to relocations. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerARM32.h
diff --git a/src/IceAssemblerARM32.h b/src/IceAssemblerARM32.h
index 2e141c13105a00dbea1751b78d3060f2ab63e5dc..02f996ceb6690a4bc2e23d5ee31e673a1a36d3ce 100644
--- a/src/IceAssemblerARM32.h
+++ b/src/IceAssemblerARM32.h
@@ -46,6 +46,7 @@ class MoveRelocatableFixup final : public AssemblerFixup {
public:
MoveRelocatableFixup() = default;
size_t emit(GlobalContext *Ctx, const Assembler &Asm) const final;
+ void emitOffset(Assembler *Asm) const;
};
/// Handles encoding of branch and link to global location.
@@ -56,6 +57,7 @@ class BlRelocatableFixup final : public AssemblerFixup {
public:
BlRelocatableFixup() = default;
size_t emit(GlobalContext *Ctx, const Assembler &Asm) const final;
+ void emitOffset(Assembler *Asm) const;
};
class AssemblerARM32 : public Assembler {
@@ -636,9 +638,6 @@ private:
void emitBranch(Label *L, CondARM32::Cond, bool Link);
- // Encodes the given Offset into the branch instruction Inst.
- IValueT encodeBranchOffset(IOffsetT Offset, IValueT Inst);
-
// Returns the offset encoded in the branch instruction Inst.
static IOffsetT decodeBranchOffset(IValueT Inst);
« no previous file with comments | « src/IceAssembler.h ('k') | src/IceAssemblerARM32.cpp » ('j') | src/IceAssemblerARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698