Remove CFX_PtrArray from xfa's combobox.h.

Remove CFX_PtrArray from xfa's combobox.h.

patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e059b5ba126082c0303bb4d46df947f34fcb0e61

[Tom Sepez, 2016-02-05 16:35:58]

Description was changed from

==========
Remove CFX_PtrArray from xfa's combobox.h.

patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)
==========

to

==========
Remove CFX_PtrArray from xfa's combobox.h.

patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)
==========

[Tom Sepez, 2016-02-05 16:35:58]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-05 16:36:25]

Patch move onto origin/master upstream.  Still making changes from previous
review.

[Tom Sepez, 2016-02-05 16:37:59]

Carrying over comments from earlier issue number:

htts://codereview.chromium.org/1665243003/diff/1/xfa/src/fwl/src/lightwidget...
> File xfa/src/fwl/src/lightwidget/combobox.cpp (right):
> 
>
https://codereview.chromium.org/1665243003/diff/1/xfa/src/fwl/src/lightwidget...
> xfa/src/fwl/src/lightwidget/combobox.cpp:47: if (iIndex < 0 || iIndex >
> m_comboBoxData.m_ItemArray.size())
> Shouldn't this be >= ?
> 
>
https://codereview.chromium.org/1665243003/diff/1/xfa/src/fwl/src/lightwidget...
> xfa/src/fwl/src/lightwidget/combobox.cpp:54:
m_comboBoxData.m_ItemArray.clear();
> It's weird that this doesn't delete. Can we make |m_ItemArray| store
> unique_ptrs?

[Tom Sepez, 2016-02-05 17:12:55]

Ready for re-review. Thanks!

[Lei Zhang, 2016-02-05 18:49:09]

lgtm

[Tom Sepez, 2016-02-05 19:49:31]

Description was changed from

==========
Remove CFX_PtrArray from xfa's combobox.h.

patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)
==========

to

==========
Remove CFX_PtrArray from xfa's combobox.h.

patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/e059b5ba126082c0303bb4d46df947f34fcb...
==========

[Tom Sepez, 2016-02-05 19:49:32]

Committed patchset #5 (id:80001) manually as
e059b5ba126082c0303bb4d46df947f34fcb0e61 (presubmit successful).