Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: xfa/include/fwl/lightwidget/combobox.h

Issue 1669313002: Remove CFX_PtrArray from xfa's combobox.h. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Meh, map and memory are both m-words. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/src/fwl/src/lightwidget/combobox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/include/fwl/lightwidget/combobox.h
diff --git a/xfa/include/fwl/lightwidget/combobox.h b/xfa/include/fwl/lightwidget/combobox.h
index 971c64b1bbdb704016c0bff8b77984ee011856c3..db6db39d2f5c8c31e67b82f0af148147a8cf7b20 100644
--- a/xfa/include/fwl/lightwidget/combobox.h
+++ b/xfa/include/fwl/lightwidget/combobox.h
@@ -4,22 +4,28 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef _FWL_COMBOBOX_LIGHT_H
-#define _FWL_COMBOBOX_LIGHT_H
-class CFWL_Widget;
+#ifndef XFA_INCLUDE_FWL_LIGHTWIDGET_COMBOBOX_H_
+#define XFA_INCLUDE_FWL_LIGHTWIDGET_COMBOBOX_H_
+
+#include <memory>
+#include <vector>
+
+#include "xfa/include/fwl/basewidget/fwl_combobox.h"
+#include "xfa/include/fwl/lightwidget/widget.h"
+
class CFWL_WidgetProperties;
class IFWL_ComboBoxDP;
-class CFWL_ComboBox;
class CFWL_ComboBoxDP;
class CFWL_ComboBoxItem;
+
class CFWL_ComboBox : public CFWL_Widget {
public:
static CFWL_ComboBox* Create();
FWL_ERR Initialize(const CFWL_WidgetProperties* pProperties = NULL);
int32_t AddString(const CFX_WideStringC& wsText);
int32_t AddString(const CFX_WideStringC& wsText, CFX_DIBitmap* pIcon);
- int32_t RemoveAt(int32_t iIndex);
- int32_t RemoveAll();
+ bool RemoveAt(int32_t iIndex); // Returns false iff |iIndex| out of range.
+ void RemoveAll();
int32_t CountItems();
FWL_ERR GetTextByIndex(int32_t iIndex, CFX_WideString& wsText);
int32_t GetCurSel();
@@ -113,12 +119,13 @@ class CFWL_ComboBox : public CFWL_Widget {
FX_DWORD dwCheckState);
virtual FX_FLOAT GetListHeight(IFWL_Widget* pWidget);
- CFX_PtrArray m_arrItem;
+ std::vector<std::unique_ptr<CFWL_ComboBoxItem>> m_ItemArray;
FX_FLOAT m_fMaxListHeight;
FX_FLOAT m_fItemHeight;
};
CFWL_ComboBoxDP m_comboBoxData;
};
+
class CFWL_ComboBoxItem {
public:
CFWL_ComboBoxItem() {
@@ -133,4 +140,5 @@ class CFWL_ComboBoxItem {
CFX_RectF m_rtCheckBox;
void* m_pData;
};
-#endif
+
+#endif // XFA_INCLUDE_FWL_LIGHTWIDGET_COMBOBOX_H_
« no previous file with comments | « no previous file | xfa/src/fwl/src/lightwidget/combobox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698