Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1668983002: Resynthesize 'String.length' getter references in constants. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize 'String.length' getter references in constants. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/29e7d0177baaa3e9fb7d29bf0e1551c57c9d2ced

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +18 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +97 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-04 20:51:14 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-04 21:08:36 UTC) #2
scheglov
4 years, 10 months ago (2016-02-04 21:11:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29e7d0177baaa3e9fb7d29bf0e1551c57c9d2ced (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698