Resynthesize 'String.length' getter references in constants.

pkg/analyzer/test/src/summary/resynthesize_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
@@ skipping 250 matching lines @@
       expect(r, isNull, reason: desc);
     } else {
       expect(r, isNotNull, reason: desc);
       // ConstantAstCloner does not copy static types, and constant values
       // computer does not use static types. So, we don't set them during
       // resynthesis and should not check them here.
       if (o is ParenthesizedExpression) {
         // We don't resynthesize parenthesis, so just ignore it.
         compareConstantExpressions(r, o.expression, desc);
       } else if (o is SimpleIdentifier && r is SimpleIdentifier) {
-        expect(r.name, o.name);
+        expect(r.name, o.name, reason: desc);
         compareElements(r.staticElement, o.staticElement, desc);
       } else if (o is PrefixedIdentifier && r is SimpleIdentifier) {
         // We don't resynthesize prefixed identifiers.
         // We use simple identifiers with correct elements.
         compareConstantExpressions(r, o.identifier, desc);
+      } else if (o is PropertyAccess && r is PropertyAccess) {
+        compareConstantExpressions(r.target, o.target, desc);
+        expect(r.propertyName.name, o.propertyName.name, reason: desc);
+        compareElements(
+            r.propertyName.staticElement, o.propertyName.staticElement, desc);
       } else if (o is PropertyAccess && r is SimpleIdentifier) {
         // We don't resynthesize property access.
         // We use simple identifiers with correct elements.
         compareConstantExpressions(r, o.propertyName, desc);
       } else if (o is NullLiteral) {
         expect(r, new isInstanceOf<NullLiteral>(), reason: desc);
       } else if (o is BooleanLiteral && r is BooleanLiteral) {
         expect(r.value, o.value, reason: desc);
       } else if (o is IntegerLiteral && r is IntegerLiteral) {
         expect(r.value, o.value, reason: desc);
@@ skipping 943 matching lines @@
 class C {
   const C();
 }
 ''');
     checkLibrary(r'''
 import 'a.dart' as p;
 const V = const p.C();
 ''');
   }
 
+  test_const_length_ofClassConstField() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+class C {
+  static const String F = '';
+}
+const int v = C.F.length;
+''');
+  }
+
+  test_const_length_ofClassConstField_imported() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+class C {
+  static const String F = '';
+}
+''');
+    checkLibrary(r'''
+import 'a.dart';
+const int v = C.F.length;
+''');
+  }
+
+  test_const_length_ofClassConstField_imported_withPrefix() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+class C {
+  static const String F = '';
+}
+''');
+    checkLibrary(r'''
+import 'a.dart' as p;
+const int v = p.C.F.length;
+''');
+  }
+
+  test_const_length_ofStringLiteral() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+const v = 'abc'.length;
+''');
+  }
+
+  test_const_length_ofTopLevelVariable() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+const String S = 'abc';
+const v = S.length;
+''');
+  }
+
+  test_const_length_ofTopLevelVariable_imported() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+const String S = 'abc';
+''');
+    checkLibrary(r'''
+import 'a.dart';
+const v = S.length;
+''');
+  }
+
+  test_const_length_ofTopLevelVariable_imported_withPrefix() {
+    shouldCompareConstValues = true;
+    addLibrarySource(
+        '/a.dart',
+        r'''
+const String S = 'abc';
+''');
+    checkLibrary(r'''
+import 'a.dart' as p;
+const v = p.S.length;
+''');
+  }
+
+  test_const_length_staticMethod() {
+    shouldCompareConstValues = true;
+    checkLibrary(r'''
+class C {
+  static int length() => 42;
+}
+const v = C.length;
+''');
+  }
+
   test_const_reference_staticField() {
     shouldCompareConstValues = true;
     checkLibrary(r'''
 class C {
   static const int F = 42;
 }
 const V = C.F;
 ''');
   }
 
@@ skipping 1239 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }