Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1668973002: Fix AppWindow access to uninitialized AppWindowContents. (Closed)

Created:
4 years, 10 months ago by David Tseng
Modified:
4 years, 10 months ago
Reviewers:
Devlin, yawano
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AppWindow access to uninitialized AppWindowContents. TEST=reproduction in bug no longer occurs. BUG=576607 Committed: https://crrev.com/c607f296b375457f194847f97152b8aff55a2647 Cr-Commit-Position: refs/heads/master@{#374728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M extensions/browser/app_window/app_window.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
David Tseng
4 years, 10 months ago (2016-02-04 20:10:23 UTC) #3
yawano
lgtm. Please also get another l-g-t-m from the OWNER of this file.
4 years, 10 months ago (2016-02-05 00:35:22 UTC) #4
David Tseng
+ rdevlin for e/b/a/app_window.cc
4 years, 10 months ago (2016-02-05 00:42:05 UTC) #6
Devlin
lgtm. Sorry for the delay.
4 years, 10 months ago (2016-02-10 18:02:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668973002/1
4 years, 10 months ago (2016-02-10 20:27:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 21:28:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c607f296b375457f194847f97152b8aff55a2647
Cr-Commit-Position: refs/heads/master@{#374728}

Powered by Google App Engine
This is Rietveld 408576698