extensions/browser/app_window/app_window.cc - Issue 1668973002: Fix AppWindow access to uninitialized AppWindowContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 1668973002: Fix AppWindow access to uninitialized AppWindowContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index e328ecfc9c045c5fd88bee014b391ab9a343578a..5bb73e65f741281d507f804a1b889fcf9bfc79ea 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -520,7 +520,9 @@ void AppWindow::OnNativeWindowActivated() {

}

content::WebContents* AppWindow::web_contents() const {

- return app_window_contents_->GetWebContents();

+ if (app_window_contents_)

+ return app_window_contents_->GetWebContents();

+ return nullptr;

}

const Extension* AppWindow::GetExtension() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »