Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1668813002: Fix an assertion failure in CXFA_DefFontMgr::GetDefaultFont() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix an assertion failure in CXFA_DefFontMgr::GetDefaultFont() BUG=pdfium:385 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/db8c35617cca9bb204648eb5702fd30b709a1c19

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M xfa/src/fxfa/src/app/xfa_ffdocview.h View 1 chunk +1 line, -2 lines 1 comment Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 3 chunks +5 lines, -11 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 4 chunks +22 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jun_fang
Hi Tom and Lei, Please help to review this CL. Thanks! https://codereview.chromium.org/1668813002/diff/1/xfa/src/fxfa/src/app/xfa_ffdocview.h File xfa/src/fxfa/src/app/xfa_ffdocview.h (left): ...
4 years, 10 months ago (2016-02-04 12:10:00 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-04 17:43:58 UTC) #3
jun_fang
4 years, 10 months ago (2016-02-05 01:58:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
db8c35617cca9bb204648eb5702fd30b709a1c19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698