Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/core/page/ContextMenuController.cpp

Issue 1668553003: Fix server-side image map click location with "Open link in new tab" Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: appendServerMapMousePosition function made static Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ContextMenuController.cpp
diff --git a/third_party/WebKit/Source/core/page/ContextMenuController.cpp b/third_party/WebKit/Source/core/page/ContextMenuController.cpp
index 515a3e18c942d861d8dcb83dd00d236a05e8ae49..2de007b7b6b8db53393e1193414a963bc2ed36ff 100644
--- a/third_party/WebKit/Source/core/page/ContextMenuController.cpp
+++ b/third_party/WebKit/Source/core/page/ContextMenuController.cpp
@@ -173,7 +173,7 @@ PassOwnPtr<ContextMenu> ContextMenuController::createContextMenu(LocalFrame* fra
void ContextMenuController::showContextMenu(Event* event)
{
- m_client->showContextMenu(m_contextMenu.get());
+ m_client->showContextMenu(m_contextMenu.get(), event);
tkent 2016/02/05 02:05:47 |event| can be nullptr. It causes a crash in appe
JakeYoon 2016/02/05 04:04:49 How do you think to add to check nullptr in append
zino 2016/02/05 05:47:34 I'm not owner but I think you could modify appendS
tkent 2016/02/05 06:00:45 Check it in ContextMenuClientImpl::showContextMenu
JakeYoon 2016/02/05 07:28:34 Okay, I think so too
if (event)
event->setDefaultHandled();
}

Powered by Google App Engine
This is Rietveld 408576698