Fix server-side image map click location with "Open link in new tab"

third_party/WebKit/Source/core/page/ContextMenuController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Igalia S.L
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 155 matching lines @@
     if (!result.innerNodeOrImageMapImage())
         return nullptr;
 
     m_hitTestResult = result;
 
     return adoptPtr(new ContextMenu);
 }
 
 void ContextMenuController::showContextMenu(Event* event)
 {
-    m_client->showContextMenu(m_contextMenu.get());
+    m_client->showContextMenu(m_contextMenu.get(), event);

[tkent, 2016/02/05 02:05:47]

|event| can be nullptr.  It causes a crash in appendServerMapMousePosition().

[JakeYoon, 2016/02/05 04:04:49]

How do you think to add to check nullptr in appendServerMapMousePosition()
function?

[zino, 2016/02/05 05:47:34]

I'm not owner but I think you could modify appendServerMapMousePosition() so
that the method takes mouse position instead of event object.
Then, you can get the current position from hit test result in
ContextMenuClientImpl::showContextMenu() without passing event object.

[tkent, 2016/02/05 06:00:45]

Check it in ContextMenuClientImpl::showContextMenu is cleaner, I think.

[JakeYoon, 2016/02/05 07:28:34]

Okay, I think so too

     if (event)
         event->setDefaultHandled();
 }
 
 void ContextMenuController::contextMenuItemSelected(const ContextMenuItem* item)
 {
     ASSERT(item->type() == ActionType || item->type() == CheckableActionType);
 
     if (item->action() < ContextMenuItemBaseCustomTag || item->action() > ContextMenuItemLastCustomTag)
         return;
 
     ASSERT(m_menuProvider);
     m_menuProvider->contextMenuItemSelected(item);
 }
 
 } // namespace blink