[Password Manager] Switch password manager code to use the Feature framework.

components/password_manager/core/common/password_manager_features.h

Index: components/password_manager/core/common/password_manager_features.h
diff --git a/components/password_manager/core/common/password_manager_features.h b/components/password_manager/core/common/password_manager_features.h
index 32cfcb82683aad4a4c5edc8750a097ae8c1805ff..a7d87022dfd0b3ca6710873c46d74bfa18318260 100644
--- a/components/password_manager/core/common/password_manager_features.h
+++ b/components/password_manager/core/common/password_manager_features.h
@@ -17,10 +17,15 @@ namespace features {
 // All features in alphabetical order. The features should be documented
 // alongside the definition of their values in the .cc file.
 
+extern const base::Feature kAffiliationBasedMatching;
+extern const base::Feature kDropSyncCredential;
 extern const base::Feature kEnableAutomaticPasswordSaving;
 extern const base::Feature kEnableManualPasswordGeneration;
 extern const base::Feature kEnablePasswordChangeSupport;
 extern const base::Feature kEnablePasswordForceSaving;
+extern const base::Feature kManagerForSyncSignin;

[vabr (Chromium), 2016/02/26 09:43:41]

We should not need this, could we just drop it?

[Pritam Nikam, 2016/02/26 12:42:23]

Acknowledged.

This will be resolved in separate CL.
BUG: http://crbug.com/586107

[vabr (Chromium), 2016/02/26 12:54:41]

Thanks, that's great. Still, I would not even introduce this as a new feature,
if it is to be deleted. I see two options for this:

(1) Do the removal CL first, and rebase this one on that removal. That way you
get rid of the command flags and will not have to create this
feature-to-be-deleted either.

(2) Keep the manager-for-sync-signin command-line flag for now, and first remove
the command flags file once you get to remove manager-for-sync-signin in a
subsequent CL.

The reason is to avoid confusion. If someone will read the code and wonder why
we have the kManagerForSyncSignin feature, they would currently hit this CL as
adding it. Unless they read also the review discussion and do some further
git-archeology, it won't be clear to them, why this was added. So it's better to
just remove it as a flag, not as a feature.

[Pritam Nikam, 2016/02/26 14:10:29]

Done.

Submitted a CL to remove the feature flag.
Review URL: https://codereview.chromium.org/1744513002/

+extern const base::Feature kProtectSyncCredential;
+extern const base::Feature kProtectSyncCredentialOnReauth;
 
 }  // namespace features