chrome/browser/password_manager/chrome_password_manager_client.h - Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes to fieldtrial_testing_config_*.json Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/android/password_ui_view_android.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | components/password_manager/core/browser/affiliation_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 97b2d4050161ca4c1f4b53da8222a603448e54f7..087e276b7f8d7cac3bfd14f110235778fed68595 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -99,9 +99,6 @@ class ChromePasswordManagerClient

// the sad old Infobar UI.

static bool IsTheHotNewBubbleUIEnabled();

- // Returns true if the password manager should be enabled during sync signin.

- static bool EnabledForSyncSignin();

vabr (Chromium) 2016/02/26 09:43:41 Please split this change (fixing http://crbug.com/

Pritam Nikam 2016/02/26 12:42:23 Will address this in separate CL.

protected:

// Callable for tests.

ChromePasswordManagerClient(content::WebContents* web_contents,