Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes to fieldtrial_testing_config_*.json Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 content::WebContents* contents, 92 content::WebContents* contents,
93 autofill::AutofillClient* autofill_client); 93 autofill::AutofillClient* autofill_client);
94 94
95 // Observer for PasswordGenerationPopup events. Used for testing. 95 // Observer for PasswordGenerationPopup events. Used for testing.
96 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer); 96 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
97 97
98 // Returns true if the bubble UI is enabled, and false if we're still using 98 // Returns true if the bubble UI is enabled, and false if we're still using
99 // the sad old Infobar UI. 99 // the sad old Infobar UI.
100 static bool IsTheHotNewBubbleUIEnabled(); 100 static bool IsTheHotNewBubbleUIEnabled();
101 101
102 // Returns true if the password manager should be enabled during sync signin.
103 static bool EnabledForSyncSignin();
vabr (Chromium) 2016/02/26 09:43:41 Please split this change (fixing http://crbug.com/
Pritam Nikam 2016/02/26 12:42:23 Will address this in separate CL.
104
105 protected: 102 protected:
106 // Callable for tests. 103 // Callable for tests.
107 ChromePasswordManagerClient(content::WebContents* web_contents, 104 ChromePasswordManagerClient(content::WebContents* web_contents,
108 autofill::AutofillClient* autofill_client); 105 autofill::AutofillClient* autofill_client);
109 106
110 private: 107 private:
111 friend class content::WebContentsUserData<ChromePasswordManagerClient>; 108 friend class content::WebContentsUserData<ChromePasswordManagerClient>;
112 109
113 // content::WebContentsObserver overrides. 110 // content::WebContentsObserver overrides.
114 bool OnMessageReceived(const IPC::Message& message, 111 bool OnMessageReceived(const IPC::Message& message,
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 scoped_ptr<password_manager::LogManager> log_manager_; 179 scoped_ptr<password_manager::LogManager> log_manager_;
183 180
184 // Set during 'NotifyUserAutoSigninBlockedOnFirstRun' in order to store the 181 // Set during 'NotifyUserAutoSigninBlockedOnFirstRun' in order to store the
185 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'. 182 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
186 scoped_ptr<autofill::PasswordForm> form_blocked_on_first_run_; 183 scoped_ptr<autofill::PasswordForm> form_blocked_on_first_run_;
187 184
188 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 185 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
189 }; 186 };
190 187
191 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 188 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698