chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses the review inputs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | components/password_manager/core/browser/affiliation_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index 4989deb36454a1113af6bb2d56d4b6cb2a112bfe..eeca72c4802b3445b49adb416bc4f783a05c1ffe 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -8,7 +8,6 @@

#include <string>

-#include "base/command_line.h"

#include "base/macros.h"

#include "base/metrics/field_trial.h"

#include "base/strings/string16.h"

@@ -26,10 +25,10 @@

#include "components/password_manager/core/browser/log_receiver.h"

#include "components/password_manager/core/browser/log_router.h"

#include "components/password_manager/core/browser/password_manager_internals_service.h"

+#include "components/password_manager/core/browser/password_manager_test_utils.h"

#include "components/password_manager/core/common/credential_manager_types.h"

#include "components/password_manager/core/common/password_manager_features.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

-#include "components/password_manager/core/common/password_manager_switches.h"

#include "components/prefs/pref_registry_simple.h"

#include "components/prefs/pref_service.h"

#include "components/prefs/testing_pref_service.h"

@@ -168,11 +167,8 @@ TEST_F(ChromePasswordManagerClientTest,

TEST_F(ChromePasswordManagerClientTest,

IsAutomaticPasswordSavingEnabledWhenFlagIsSetTest) {

// Add the enable-automatic-password-saving feature.

- base::FeatureList::ClearInstanceForTesting();

- scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);

- feature_list->InitializeFromCommandLine(

- password_manager::features::kEnableAutomaticPasswordSaving.name, "");

- base::FeatureList::SetInstance(std::move(feature_list));

+ EnableFeature(password_manager::features::kEnableAutomaticPasswordSaving,

+ true);

if (chrome::GetChannel() == version_info::Channel::UNKNOWN)

EXPECT_TRUE(GetClient()->IsAutomaticPasswordSavingEnabled());