chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses the review inputs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/password_ui_view_android.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | components/password_manager/core/browser/affiliation_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index f0dabfa3f24fbc6e3617e02fab9c7ec37b9994c1..863b29a45c404ec14830332bd152b210c3bc70bd 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -46,7 +46,6 @@

#include "components/password_manager/core/common/credential_manager_types.h"

#include "components/password_manager/core/common/password_manager_features.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

-#include "components/password_manager/core/common/password_manager_switches.h"

#include "components/password_manager/sync/browser/password_sync_util.h"

#include "components/prefs/pref_service.h"

#include "components/signin/core/browser/signin_manager.h"

@@ -572,14 +571,15 @@ bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {

}

bool ChromePasswordManagerClient::EnabledForSyncSignin() {

- base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

- if (command_line->HasSwitch(

- password_manager::switches::kDisableManagerForSyncSignin))

+ if (password_manager_util::IsFeatureDisabledFromCommandLine(

+ password_manager::features::kManagerForSyncSignin)) {

Bernhard Bauer 2016/02/11 11:12:40 I don't think this is necessary; FeatureList will

Pritam Nikam 2016/02/25 14:16:06 Done.

return false;

+ }

- if (command_line->HasSwitch(

- password_manager::switches::kEnableManagerForSyncSignin))

+ if (base::FeatureList::IsEnabled(

+ password_manager::features::kManagerForSyncSignin)) {

return true;

+ }

// Default is enabled.

std::string group_name =