Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1668483004: Merge to XFA: Fix prototypes for CPDF_FormNotify. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix prototypes for CPDF_FormNotify. Original Review URL: https://codereview.chromium.org/1660633003 . (cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227) Conflicts: fpdfsdk/include/fsdk_baseform.h fpdfsdk/src/fsdk_baseform.cpp TBR=thestig@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/d6262c1d5a83baa59d7927c646f8d62febd594b0

Patch Set 1 #

Patch Set 2 : One more identifier to replace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -113 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +10 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +14 lines, -17 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 3 chunks +70 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, some small manual edits.
4 years, 10 months ago (2016-02-03 22:46:28 UTC) #1
Tom Sepez
Committed patchset #2 (id:20001) manually as d6262c1d5a83baa59d7927c646f8d62febd594b0 (presubmit successful).
4 years, 10 months ago (2016-02-03 22:47:11 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-03 23:00:43 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698