Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1660633003: Fix prototypes for CPDF_FormNotify. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix prototypes for CPDF_FormNotify. Avoid some const casts, unused return types, etc. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -112 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +10 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +14 lines, -17 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 3 chunks +69 lines, -83 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, pls. review.
4 years, 10 months ago (2016-02-03 20:46:21 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-03 21:39:13 UTC) #3
Tom Sepez
4 years, 10 months ago (2016-02-03 22:40:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698