Create ElementAnnotation objects prior to resolution.

Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/50248829053444be8299e19c342d0bb348506e3a

[Paul Berry, 2016-02-03 22:15:41]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Paul Berry, 2016-02-03 22:15:41]

Note: this differs from my previous
attempt (https://codereview.chromium.org/1660713002) in the
following ways:

- Previously, ElementAnnotation objects for import, export, part,
  and library declarations were created by
  DirectiveElementBuilder.  Now these objects are created by
  ElementBuilder, and DirectiveElementBuilder merely connects
  them up to their respective elements once those elements are
  available.

- We no longer pay attention to annotations on `part of`
  directives.  This avoids the problems that broke the analyzer
  bot last night (see
 
https://github.com/dart-lang/sdk/commit/36f5c1eeb4e8143702f35ae398191f61daa9d8c3).
  It also avoids creating an ambiguity in the element model,
  since both `part of` and `library` directives point to the same
  library element.

- We no longer create a pointer from the ElementAnnotation object
  back to the element it decorates (we can't, because in the case
  of variable declarations, a single annotation may decorate
  multiple elements).

- We create a pointer from the ElementAnnotation object to the
  compilation unit in which it is declared.  This will be made
  use of in a future CL, as part of the fix for #25285.

[Brian Wilkerson, 2016-02-03 22:31:21]

LGTM

[Paul Berry, 2016-02-04 13:21:38]

Description was changed from

==========
Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.
==========

to

==========
Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/50248829053444be8299e19c342d0bb348506e3a
==========

[Paul Berry, 2016-02-04 13:21:39]

Committed patchset #1 (id:1) manually as
50248829053444be8299e19c342d0bb348506e3a (presubmit successful).